-
Notifications
You must be signed in to change notification settings - Fork 33
[Transform] Support loading random hadamards on meta device #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kyle Sayers <[email protected]>
93ed24a
to
87c9b36
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a suggestion below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main question regarding id()
vs. .data_ptr()
, but otherwise LGTM
Signed-off-by: Kyle Sayers <[email protected]>
a5e4570
Signed-off-by: Kyle Sayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Purpose
Prerequisites
Changes
_update_tied_weights
to_tie_offloaded_tensors
apply
in order to avoid redundant work_dynamic_tied_weights_keys
statically defined on the transform moduleTesting
test_serialization
tests to check the serialized values for correctnesstest_serialization_offload
tests now that the latest transformers has released