Skip to content

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Sep 4, 2025

Purpose

Prerequisites

Changes

  • Rename _update_tied_weights to _tie_offloaded_tensors
    • The new name and comments makes its to make its purpose more clear
    • Move to apply in order to avoid redundant work
  • Make _dynamic_tied_weights_keys statically defined on the transform module
    • This does not have any implications, as transformers does not check if the keys are strictly shared or even exist
  • When fetching random hadamards, load them on the cpu, even if the device is meta

Testing

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs force-pushed the kylesayrs/support-randhad-meta branch from 93ed24a to 87c9b36 Compare September 8, 2025 19:52
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
fynnsu
fynnsu previously approved these changes Sep 9, 2025
Copy link
Contributor

@fynnsu fynnsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a suggestion below.

Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main question regarding id() vs. .data_ptr(), but otherwise LGTM

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs dismissed stale reviews from brian-dellabetta and fynnsu via a5e4570 September 11, 2025 18:41
Signed-off-by: Kyle Sayers <[email protected]>
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fynnsu fynnsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kylesayrs kylesayrs merged commit de9cfc6 into main Sep 17, 2025
2 checks passed
@kylesayrs kylesayrs deleted the kylesayrs/support-randhad-meta branch September 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants