[DO NOT MERGE] Renamed Scheduler APIs to better reflect their usage. #116
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it is called for request processing
…o better indicate that it is invoked for response processing. Refactored function to separate out explicit PostResponse handling.
elevran
requested changes
May 5, 2025
|
/hold |
elevran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR renames the two APIs of the Scheduler. In particular:
In addition the code in the function Scheduler.OnResponse that is specific to PostResponse plugin handling has been moved to a new private function Scheduler.runPostResponsePlugins, in the style of th functions that drive the handling of the other plugins.