Skip to content

Conversation

@JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Sep 8, 2025

This PR renames 'Name templates' to 'Validation templates' (these are custom templates that can be validated against). Name templates is unfinformative as a name so it needs to be changed.

Unfortunately it is used in many places across the codebase, including in the configs. Therefore, a new entry into the config-loader is created to find "name_template" as an entry and convert it to "validation_template", for backwards compatability. The name is also updated in the TUI.

Tests and docs are also updated. Note SonarCloud is failing, but it is safe to ignore in this case.,

@JoeZiminski JoeZiminski changed the title Rename 'name templates' to 'validation templates'. Rename name templates to validation templates Sep 8, 2025
@JoeZiminski JoeZiminski force-pushed the rename_name_templates branch 2 times, most recently from 691fd4c to 4d9a491 Compare September 8, 2025 17:17
@JoeZiminski JoeZiminski linked an issue Sep 8, 2025 that may be closed by this pull request
@JoeZiminski JoeZiminski force-pushed the rename_name_templates branch from ae6d04b to 3f76f58 Compare October 23, 2025 16:36
@JoeZiminski JoeZiminski requested a review from viktorpm October 24, 2025 15:22
@viktorpm
Copy link

viktorpm commented Nov 4, 2025

I checked out the branch locally and tried creating a validation template. Everything seems to be working as expected.
A few comments and suggestions:

  • This sentence is a bit confusing:

    A 'Template' can be set check subject or session names are formatted in a specific way.

    suggestion:

    You can define a custom “Template” to make sure subject or session names follow a particular pattern or format.

  • Not sure if SonarCloud Code Analysis test is important, but it failed

  • Missing closing bracket (might already be fixed in the rebuilt site):

image

Copy link

@viktorpm viktorpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I added a few general comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make 'Name Templates' title clearer in the documentation

3 participants