NRNMPI_DYNAMIC_INCLUDE_FILEs are located in PROJECT_BINARY_DIR...

[nrnhines]

The intention is to fix an apparent race during a parallel build. ie.

Generating src/nrnmpi/nrnmpi_dynam.h, src/nrnmpi/nrnmpi_dynam_cinc, src/nrnmpi/nrnmpi_dynam_wrappers.inc
In file included from src/nrnmpi/nrnmpi.cpp:11:
build/temp.macosx-10.9-x86_64-cpython-311/src/nrnmpi/nrnmpi_dynam.h:6:2: error: unterminated conditional directive
#if NRNMPI_DYNAMICLOAD
 ^
build/temp.macosx-10.9-x86_64-cpython-311/src/nrnmpi/nrnmpi_dynam.h:2:2: error: unterminated conditional directive
#ifndef nrnmpi_dynam_h
 ^

Under the assumption that the issue is related to mkdynam.sh OUTPUT files being created but taking some time being completed, I tested by adding this fragment near the beginning of mkdynam.sh

+touch "${NRNMPI_OUTPUT_PATH}/nrnmpi_dynam_wrappers.inc"
+touch "${NRNMPI_OUTPUT_PATH}/nrnmpi_dynam.h"
+touch "${NRNMPI_OUTPUT_PATH}/nrnmpi_dynam_cinc"
+sleep 20

and then the rest of mkdynam.sh appending to those files. A clean build with make -j 8 did exhibit the problem, though my one attempt with ninja was a success.

$ cmake .. -DCMAKE_INSTALL_PREFIX=install -DNRN_ENABLE_MPI_DYNAMIC=ON -DNRN_ENABLE_PYTHON_DYNAMIC=ON
$ make -j 8
[ 97%] Generating /home/hines/neuron/temp2/src/nrnmpi/nrnmpi_dynam.h, /home/hines/neuron/temp2/src/nrnmpi/nrnmpi_dynam_cinc, /home/hines/neuron/temp2/src/nrnmpi/nrnmpi_dynam_wrappers.inc
[ 98%] Building CXX object src/nrniv/CMakeFiles/nrniv_lib.dir/__/nrnmpi/nrnmpi_dynam.cpp.o
In file included from /home/hines/neuron/temp2/src/nrnmpi/nrnmpi_dynam.cpp:39:
/home/hines/neuron/temp2/build/src/nrnmpi/nrnmpi_dynam_cinc:173:21: error: redefinition of ‘bbsmpibuf* (* p_nrnmpi_newbuf)(int)’
  173 | static bbsmpibuf* (*p_nrnmpi_newbuf)(int size);
      |                     ^~~~~~~~~~~~~~~

With this PR fix, both ninja and make -j 8 succeed with the test version of mkdynam.sh

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[JCGoran]

Nice catch! The CI failure looks unrelated to this change (I think we're hitting pypa/pip#11153 again), just re-run it once the other Azure jobs finish and it should be good.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (e0cbb32) to head (b26adc8).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3347   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files         682      682           
  Lines      116435   116435           
=======================================
  Hits        79541    79541           
  Misses      36894    36894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[azure-pipelines]

✔️ b26adc8 -> Azure artifacts URL