Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init repo and migrate image registry controller #1

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

Levi080513
Copy link
Collaborator

@Levi080513 Levi080513 commented Mar 7, 2025

Issues

https://github.com/neutree-ai/prototype/issues/2

Changes

  1. init repo
  2. migrate image registry controller

Test

Removed the image registry controller from the prototype, the image registry keep reconcile.
image

Deleteing image registry,image registry status change to Deleted.
image

And in the next reconcile, image registry delete success.
image

@Levi080513 Levi080513 requested a review from Yuyz0112 March 7, 2025 04:48
@@ -0,0 +1,107 @@
package postgrest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s better to encapsulate this layer as an API client, keeping PostgREST as an internal concept to allow for future migration.

@Yuyz0112 Yuyz0112 merged commit 2ddd13c into main Mar 7, 2025
1 check passed
@Levi080513 Levi080513 deleted the huangwei/init branch April 1, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants