feat: migrate model registry controller #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuyz0112
reviewed
Mar 12, 2025
| @@ -43,7 +43,9 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=${ARCH} \ | |||
| go build "${GO_BUILD_ARGS}" \ | |||
| -o neutree-core cmd/main.go | |||
|
|
|||
| FROM --platform=linux/${ARCH} alpine:3 | |||
| FROM --platform=linux/${ARCH} alpine:3.18 | |||
There was a problem hiding this comment.
Shall we manage python deps in requirements.txt?
pkg/model_registry/bentoml.go
Outdated
| @@ -0,0 +1,132 @@ | |||
| package model_registry | |||
There was a problem hiding this comment.
move this to an internal bentoml folder may maybe better for future re-use
There was a problem hiding this comment.
and we'd better name this kind of model registry to file-based, which will not be bound to the internal implementation.
pkg/utils/nfs.go
Outdated
| @@ -0,0 +1,52 @@ | |||
| package utils | |||
There was a problem hiding this comment.
how about moving to internal/nfs?
Yuyz0112
reviewed
Mar 12, 2025
| @@ -0,0 +1 @@ | |||
| bentoml | |||
There was a problem hiding this comment.
add a version descriptor to it
Yuyz0112
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
migrate model registry controller
Changes
Test
model registry status
nfs mount points for
bentomltest
bentoml models list