[V0.10] Check the H.264 library works before trying to load it #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found during deployment that it is possible for some configurations to have the build-time noopenh264 library installed, rather than the openh264 library. This causes a failure which is difficult to diagnose. (cherry picked from commit 195d04a)
|
Testing on Alma 9.5.
Another log in over xrdp worked. Then:- $ sudo grep '2025-02-13.*264' /var/log/xrdp.log [2025-02-13T11:42:58.585+0000] [INFO ] xrdp_encoder_create: using OpenH264 for software encoder [2025-02-13T11:44:27.852+0000] [ERROR] OpenH264 Codec is not installed correctly. H.264 will not be used |
|
@metalefty - I've updated the wiki in anticipation that you're happy with this. Please merge it if you are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3413, without the changes to the missing Coverity file.
Draft for now while I retest on Alma 9.