ci: disaster recovery dry run on prod #2017
Conversation
|
|
||
| - name: set README and a file that will not be rolled back | ||
| run: | | ||
| echo "This folder is meant to test the disaster recevery dry-run." > DISASTER_TEST_README.md |
There was a problem hiding this comment.
| echo "This folder is meant to test the disaster recevery dry-run." > DISASTER_TEST_README.md | |
| echo "This folder is meant to test the disaster recovery dry-run." > DISASTER_TEST_README.md |
There was a problem hiding this comment.
Done in c160495
| echo AWS_PROFILE="${{ env.TEMP_AWS_PROFILE }}" >> $GITHUB_ENV | ||
| echo AWS_REGION="${{ env.AWS_REGION }}" >> $GITHUB_ENV | ||
| echo TEST_FOLDER_ABS_PATH="s3://${{ env.BUCKET_NAME }}/${{ env.MANDATORY_PREFIX }}/${{ env.TEST_FOLDER }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Why are those variables set up here instead of the env block at the top?
There was a problem hiding this comment.
I didn't want to expose AWS_PROFILE and AWS_REGION before calling aws_credentials as it could affect that script.
The third one was just not to copy and paste the same strings on top in 2 variables :)
|
|
||
| - name: Get current datetime and sleep for a couple of minutes | ||
| run: | | ||
| now=$( date +"%m-%d-%Y %H:%M:%S %z" ) |
There was a problem hiding this comment.
Sorry I didn't spot this on the staging one. Should we add --utc to assure the date is in UTC?
🤔 Maybe it is not important since it includes %z info
There was a problem hiding this comment.
Good point. I'll add it just in case
There was a problem hiding this comment.
Done in c160495
| with: | ||
| payload: | | ||
| { | ||
| "text": ":rotating_light: Dry-Run Recover S3 Repository failed :warning: :warning: :warning: @hero check <${{ env.GITHUB_JOB_URL }}> :rotating_light:" |
There was a problem hiding this comment.
Nit: I'm not sure if we should say Dry-Run, even if it runs in a testing folder it is actually running (and failing if we get this message! 😅 )
There was a problem hiding this comment.
Sounds reasonable :) I'll rename it
There was a problem hiding this comment.
Done in c160495
Pull Request Test Coverage Report for Build 13431009553Details
💛 - Coveralls |
This PR:
--recursivefromrmwhen deleting original