Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_REF_NAME instead of GITHUB_REF #3044

Closed
wants to merge 1 commit into from

Conversation

hmstepanek
Copy link
Contributor

Overview

Previously the workflow was using GITHUB_REF which is refs/heads/tag-name instead of tag-name. This has been fixed.

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

Previously the workflow was using GITHUB_REF which is refs/heads/tag-name instead of tag-name. This has been fixed.
@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Jan 30, 2025
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hmstepanek
Copy link
Contributor Author

It looks like you already fixed it a different way which is totally fine so I'm just going to close this one.

@hmstepanek hmstepanek closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants