-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notifications channel/destination update entity): Updated provider to work with new client version #2114
base: main
Are you sure you want to change the base?
Conversation
|
|
…r to work with new client version
fbbe111
to
093a1e0
Compare
@@ -18,9 +18,10 @@ func expandNotificationChannel(d *schema.ResourceData) notifications.AiNotificat | |||
} | |||
|
|||
func expandNotificationChannelUpdate(d *schema.ResourceData) notifications.AiNotificationsChannelUpdate { | |||
active := d.Get("active").(bool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be nil if there is no active property, right?
channel := notifications.AiNotificationsChannelUpdate{ | ||
Name: d.Get("name").(string), | ||
Active: d.Get("active").(bool), | ||
Active: &active, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to upgrade the go-client version here?
Also, looks like tests are failing :) |
…issues-filter-name chore(Workflow)!: Verify non empty issues filter name
e5e037d
to
af9e827
Compare
23a73db
to
4f7b20e
Compare
Description
Please include a summary of the change and which issue is fixed (if relevant).
Currently there's no way to update the boolean field "active" to be false, as the "omitempty" tag(?) parses false as empty. The change has been done in the client and it is a breaking change, so this PR was created to work with the new version
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc