Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gov integration #2802

Merged

Conversation

vivek-tech-exp
Copy link
Contributor

Description

  1. Created separate configurations for gov cloud.
  2. applied correct resources assigned for gov cloud
  3. removed aws resources for which gov cloud permissions do not allow integrations. check https://docs.newrelic.com/docs/infrastructure/amazon-integrations/connect/connect-aws-govcloud-new-relic/

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

vmankonda added 3 commits January 30, 2025 14:43
1. Created separate configurations for gov cloud.
2. applied correct resources assigned for gov cloud
3. removed aws resources for which gov cloud permissions do not allow integrations. check https://docs.newrelic.com/docs/infrastructure/amazon-integrations/connect/connect-aws-govcloud-new-relic/
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


vmankonda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vinay-newrelic vinay-newrelic merged commit c920008 into newrelic:aws_gov_cloud_changes Jan 30, 2025
3 of 4 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (aws_gov_cloud_changes@b610f48). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             aws_gov_cloud_changes    #2802   +/-   ##
========================================================
  Coverage                         ?   31.03%           
========================================================
  Files                            ?      101           
  Lines                            ?    27493           
  Branches                         ?        0           
========================================================
  Hits                             ?     8533           
  Misses                           ?    18794           
  Partials                         ?      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants