chore(workspace): approve build scripts for native dependencies#397
chore(workspace): approve build scripts for native dependencies#397damiankraskocoaching wants to merge 1 commit into
Conversation
Enable pnpm to run postinstall build scripts for packages that require native compilation: electron, better-sqlite3, sharp, esbuild, sentry/cli, and spawn-sync. Without this, pnpm blocks their build steps and the workspace cannot be installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 268f945b21
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tar: '>=7.5.11 <8' | ||
| esbuild: '>=0.25.0' | ||
| '@tootallnate/once': '>=3.0.1' | ||
|
|
||
| importers: |
There was a problem hiding this comment.
With the overrides block removed here, the lockfile no longer matches the pnpm.overrides still declared in package.json; in this tree pnpm install --frozen-lockfile fails immediately with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH. This breaks CI and fresh installs that use the committed lockfile, so the lockfile needs to be regenerated with the package overrides preserved rather than resolved without them.
Useful? React with 👍 / 👎.
1 participant
Summary
allowBuildssection topnpm-workspace.yamlapproving build scripts for all native/compiled packagespnpm-lock.yamlto reflect the resolved dependency tree after a clean installWhy
Without the
allowBuildsconfiguration, pnpm v11+ blocks postinstall build scripts for packages likeelectron,better-sqlite3,sharp,esbuild,@sentry/cli, andspawn-sync. This prevents the workspace from being installed from scratch.Reviewer notes
The
pnpm-workspace.yamlchanges are minimal and intentional - each entry explicitly opts in to native build execution. The lockfile diff reflects a clean resolution pass.Generated with Claude Code