Add Windows portable release support#402
Closed
jabrailkhalil wants to merge 4 commits into
Closed
Conversation
Author
|
Follow-up validation for commit
Checks run on Windows:
|
Author
|
Follow-up for release coverage in commit
Local validation:
|
Author
|
Follow-up for the user-facing portable folder release in commit This adds a second Windows portable distribution format in addition to electron-builder's
The folder launcher sets Release coverage:
Local validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
portableelectron-builder target alongside the existing NSIS installer.PORTABLE_EXECUTABLE_DIRfrom electron-builder, withVIDBEE_PORTABLE_DIRas a local/testing override.Why
This implements the direction proposed in #401: a no-install Windows release artifact for USB / isolated / portable use cases while preserving the existing installer behavior for normal Windows users.
The regular installer path remains unchanged because portable mode only activates when
PORTABLE_EXECUTABLE_DIRorVIDBEE_PORTABLE_DIRis present.Validation
corepack pnpm --filter ./apps/desktop run checkcorepack pnpm --filter ./apps/desktop run buildcorepack pnpm --filter ./apps/desktop exec electron-builder --win portable --publish neverThe portable packaging command produced:
Local Windows Sandbox testing from #401 also verified that the manually wrapped portable launch kept config/download paths inside the portable folder and left 0 matches in the checked host trace locations after Sandbox shutdown.