[Spring MVC] 김남우 미션제출합니다 #513
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanxiu
reviewed
Nov 23, 2025
| if (removed) { | ||
| return ResponseEntity.noContent().build(); | ||
| } else { | ||
| throw new BadRequestReservationException("Reservation not found."); |
There was a problem hiding this comment.
리소스를 찾을 수 없을 때는 NotFoundReservationException 을 던지는 게 더 적절해보네요!
| @PostMapping | ||
| public ResponseEntity<Reservation> addReservation(@RequestBody Reservation newReservation) { | ||
| // 예외 조건 추가 | ||
| if (newReservation.getName() == null || newReservation.getName().isBlank() || |
There was a problem hiding this comment.
수동으로 검증 로직을 처리하고 있네요! Valid 어노테이션을 찾아볼까요? DTO 의 필드가 제대로 입력되었는지 검증할 수 있습니다. 이 글 을 참고하면 도움이 될 것 같아요!
| private String date; | ||
| private String time; | ||
|
|
||
| public Reservation(Long id, String name, String date, String time) { |
There was a problem hiding this comment.
현재 기본 생성자가 없네요! Reservation 클래스는 컨트롤러에서 POST 요청을 보낼 때 요청 객체로 사용되는 DTO 로 구현되어있어요. 그런데 기본 생성자가 없으면 JSON 역직렬화가 불가해요. 클라가 보내는 JSON 문자열을 @RequestBody 어노테이션이 Reservation 객체로 변환하는데, 여기서 오류가 발생하겠네요.
Lombok 에서 생성자를 만들어주는 어노테이션을 찾아볼까요? 이 글 에서 세 가지 어노테이션을 잘 설명해주고 있습니다
| @RestControllerAdvice | ||
| public class ReservationExceptionHandler { | ||
| @ExceptionHandler(BadRequestReservationException.class) | ||
| public ResponseEntity<Void> handleBadRequest(BadRequestReservationException e) { |
There was a problem hiding this comment.
예외 객체 e를 받고 있네요. 이것을 활용해서 예외 메시지를 에러코드와 함께 던져볼까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3단계 - 예약 추가 / 예약 취소
4단계 - 예외 처리