BugFix - Use Long For X-Activity-Last-Given #1672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alperozturk96
changed the title
There was a problem hiding this comment.
Makes sense since PHP int size can be up to 2^63.
Likely will need to be changed elsewhere too - i.e.
- https://github.com/nextcloud/android/blob/87a2bc7e70801ad8260b9d8cc10ceb109c41a9da/app/src/main/java/com/owncloud/android/ui/activities/data/activities/ActivitiesServiceApiImpl.java#L58
- https://github.com/nextcloud/android/blob/87a2bc7e70801ad8260b9d8cc10ceb109c41a9da/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.java#L260
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
bugfix/use-long-for-GetActivitiesRemoteOperation
branch
from
86363c1 to
ee1fb0c
Compare
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3933-IT-master-14-05/debug/ |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3933-IT-stable-14-11/debug/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : X-Activity-Last-Given, exceeding the integer limit.
@tobiasKaminsky In Java, if a constructor expects a
longprimitive type, you can still pass anintprimitive type, and it will compile successfully. See the video below for reference. Therefore, there is no need to modify the Android Files Client.Screen.Recording.2025-03-03.at.14.46.00.mp4