Skip to content

Fix - AbstractIT #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix - AbstractIT #1721

wants to merge 3 commits into from

Conversation

alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented May 8, 2025

Resolved issues encountered during local environment testing with AbstractIT.

  1. The test was forcing the use http instead of https, which caused the waitForServer() function to fail.

  2. The removeOnClient() method was unable to delete files as expected, leading to test failures. File can be locked, thus remove will fail.

Copy link
Contributor

github-actions bot commented May 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented May 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@alperozturk96
Copy link
Contributor Author

alperozturk96 commented May 8, 2025

ToggleEncryptionRemoteOperation in removeOnClient() fails locally, even with these changes, but works on our server.

I'm getting a 403 Forbidden error.

The username for the local instance is "user".

Copy link
Contributor

github-actions bot commented May 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.07%. Comparing base (2d47aa4) to head (58bd46a).
Report is 83 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1721      +/-   ##
============================================
- Coverage     43.20%   43.07%   -0.13%     
- Complexity      981      988       +7     
============================================
  Files           229      235       +6     
  Lines          8490     8562      +72     
  Branches       1109     1119      +10     
============================================
+ Hits           3668     3688      +20     
- Misses         4317     4359      +42     
- Partials        505      515      +10     

see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@ZetaTom
Copy link
Contributor

ZetaTom commented Jun 4, 2025

ToggleEncryptionRemoteOperation in removeOnClient() fails locally, even with these changes, but works on our server.

I'm getting a 403 Forbidden error.

The username for the local instance is "user".

During testing we've noticed that this does indeed happen while running test cases explicitly. I've also been able to replicate this on my machine. However, when placing a breakpoint in ToggleEncryptionRemoteOperation and manually unlocking a folder in the app, a 200 status code is returned instead.

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3435
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness113
Performance88
Total168161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants