-
Notifications
You must be signed in to change notification settings - Fork 94
Fix - AbstractIT #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix - AbstractIT #1721
Conversation
847f984
to
15fd3bf
Compare
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4074-IT-stable-08-54/debug/ |
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4074-IT-master-08-55/debug/ |
ToggleEncryptionRemoteOperation in removeOnClient() fails locally, even with these changes, but works on our server. I'm getting a 403 Forbidden error. The username for the local instance is "user". |
2b42464
to
0f0a76f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1721 +/- ##
============================================
- Coverage 43.20% 43.07% -0.13%
- Complexity 981 988 +7
============================================
Files 229 235 +6
Lines 8490 8562 +72
Branches 1109 1119 +10
============================================
+ Hits 3668 3688 +20
- Misses 4317 4359 +42
- Partials 505 515 +10 🚀 New features to boost your workflow:
|
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
0f0a76f
to
70120b0
Compare
During testing we've noticed that this does indeed happen while running test cases explicitly. I've also been able to replicate this on my machine. However, when placing a breakpoint in |
library/src/androidTest/java/com/owncloud/android/AbstractIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom <[email protected]> Signed-off-by: Alper Öztürk <[email protected]>
Resolved issues encountered during local environment testing with AbstractIT.
The test was forcing the use http instead of https, which caused the waitForServer() function to fail.
The removeOnClient() method was unable to delete files as expected, leading to test failures. File can be locked, thus remove will fail.