Run tests also on older server versions

[tobiasKaminsky]

Signed-off-by: tobiasKaminsky [email protected]

[tobiasKaminsky]

@AlvaroBrey my idea is to test library on all NC server version down to NC16.
While developing this is of course not needed, so I think about something like a check if PR is approved and only then execute the entire NC21-NC16 checks.

What do you think?

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/590-IT-stable-08-59

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	2	3
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	38
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	40
Total	122

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	38
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	40
Total	122

Lint increased!

[nextcloud-android-bot]

stable-21-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/591-IT-stable-21-09-19

[AlvaroBrey]

@AlvaroBrey my idea is to test library on all NC server version down to NC16. While developing this is of course not needed, so I think about something like a check if PR is approved and only then execute the entire NC21-NC16 checks.

What do you think?

We could use the 3.to release label for this I guess, that way we mark the PR as ready to merge, and trigger the older version checks.

Other options:

• Run older versions only against master (merged PRs)
• Run older versions on a cron job daily

[tobiasKaminsky]

We could use the 3.to release label for this I guess, that way we mark the PR as ready to merge, and trigger the older version checks.

Nice idea, but I did not found a way how to notice drone.io about changed label/approved state.
Currently it seems we only listen on push
https://docs.drone.io/pipeline/triggers/

[AlvaroBrey]

We could use the 3.to release label for this I guess, that way we mark the PR as ready to merge, and trigger the older version checks.

Nice idea, but I did not found a way how to notice drone.io about changed label/approved state. Currently it seems we only listen on push https://docs.drone.io/pipeline/triggers/

We can use a github action to detect the label and then trigger the build with the drone API.

Other option is to try to work out how to run the integration tests directly on github actions, which would make it easier and would allow us to use test matrix for server versions.

[tobiasKaminsky]

Superseeded with #938