Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Use default sharing permissions #14695

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 17, 2025

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1688

Feature Issue: nextcloud/files-clients#4

How to test?

  1. Create a share without choosing any share permission (View only, Allow upload and editing, File drop (upload only))
  2. Via debugger determine what's the default permission int value
  3. Open web app and navigate to the "apps/files/shareoverview"
  4. Observe response of "ocs/v2.php/apps/files_sharing/api/v1/shares?shared_with_me=false&include_tags=true"
  5. Compare the permission field inside the data with the default permission value sent from the application.

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the feature/use-default-sharing-permissions branch from 945a821 to 5a96dc0 Compare March 18, 2025 11:13
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14695.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant