[WP #60683]display error if oidc apps not supported #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
show-error-if-not-support
branch
2 times, most recently
from
3cc84d0 to
09cf76e
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
show-error-if-not-support
branch
from
09cf76e to
a7d8d10
Compare
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
show-error-if-not-support
branch
from
63061d9 to
f704008
Compare
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
show-error-if-not-support
branch
from
2f23080 to
c8d6120
Compare
PHP Code CoverageCoverage after merging show-error-if-not-support into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
individual-it
requested changes
Feb 18, 2025
| } | ||
|
|
||
| public function isUserOIDCAppSupported(): bool { | ||
| $userOidcVersion = $this->appManager->getAppVersion('user_oidc'); |
There was a problem hiding this comment.
you check the version before checking that the app is installed. What will happen here if the app is not installed at all?
Comment on lines
+4386
to
+4397
| if (count($classesExist) === 4 && array_product(array_map('class_exists', $classesExist))) { | ||
| $service = $this->getOpenProjectAPIServiceMock( | ||
| ['isUserOIDCAppInstalledAndEnabled'], | ||
| [ | ||
| 'appManager' => $iAppManagerMock, | ||
| ], | ||
| ); | ||
| $service->method('isUserOIDCAppInstalledAndEnabled')->willReturn($installedAndEnabled); | ||
| $actualResult = $service->isUserOIDCAppSupported(); | ||
| } else { | ||
| $actualResult = false; | ||
| } |
There was a problem hiding this comment.
I don't understand that test. You only run the function when your provider has all classes in $classesExist, so what is the point in the test cases where a class is missing? You just set the result to false and check if it is false 😕
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show the error if the user_OIDC app not supported to integration_openproject
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile