fix(files_sharing): Apply default password setting in SharingDetailsTab #52121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
force-pushed
the
fix/no-issue/use-password-default-sharing-details
branch
from
72d4b39 to
f06a223
Compare
|
/compile / |
artonge
approved these changes
Apr 14, 2025
artonge
force-pushed
the
fix/no-issue/use-password-default-sharing-details
branch
from
8acec45 to
574807e
Compare
nfebe
force-pushed
the
fix/no-issue/use-password-default-sharing-details
branch
from
574807e to
44156c8
Compare
|
/compile |
Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/no-issue/use-password-default-sharing-details
branch
from
add5489 to
02efad6
Compare
|
/compile |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/52121/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 02efad60 ace09287
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52121/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When admin has set that shares should have password by default but not enforce it, this does not take effect in the sharing details tab, this change fixes that.