-
-
Notifications
You must be signed in to change notification settings - Fork 288
Refactoring Login Process to MVVM #5523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rapterjet2004
wants to merge
1
commit into
master
Choose a base branch
from
issue-5520-moving-login-to-mvvm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rapterjet2004 <[email protected]>
Contributor
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5523.apk |
mahibi
requested changes
Nov 13, 2025
Collaborator
mahibi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when trying to login with loginv2 it fails:
2025-11-13 11:48:17.326 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I []
2025-11-13 11:48:17.327 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I <-- END HTTP (2-byte body)
2025-11-13 11:48:17.586 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I --> POST https://sermo.nextcloud.com/login/v2/poll
2025-11-13 11:48:17.587 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I Content-Type: application/x-www-form-urlencoded
2025-11-13 11:48:17.587 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I Content-Length: 134
2025-11-13 11:48:17.587 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v23.0.0 Alpha 13
2025-11-13 11:48:17.588 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I Accept: application/json
2025-11-13 11:48:17.588 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I OCS-APIRequest: true
2025-11-13 11:48:17.589 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I ngrok-skip-browser-warning: true
2025-11-13 11:48:17.590 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I token=shtYa8ErLZZzeDaxg0QugStgLmki0w0Cs6R8UHuZR8dUlli1qsdzMUIsSU1saccRpghhhz4xlI0N7ix0jXvjxTZJRWybggMIqkBuo9f8OvqSxmtBBQrx2ip9w95mcgyx
2025-11-13 11:48:17.590 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I --> END POST (134-byte body)
2025-11-13 11:48:17.725 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I <-- 404 https://sermo.nextcloud.com/login/v2/poll (134ms)
2025-11-13 11:48:17.726 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I server: nginx
2025-11-13 11:48:17.726 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I date: Thu, 13 Nov 2025 10:48:17 GMT
2025-11-13 11:48:17.726 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I content-type: application/json; charset=utf-8
2025-11-13 11:48:17.726 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I content-length: 2
2025-11-13 11:48:17.726 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-request-id: NZgq7ENSbyU2iA4nE9t2
2025-11-13 11:48:17.727 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I cache-control: no-cache, no-store, must-revalidate
2025-11-13 11:48:17.727 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I content-security-policy: default-src 'none';base-uri 'none';manifest-src 'self';frame-ancestors 'none'
2025-11-13 11:48:17.727 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I feature-policy: autoplay 'none';camera 'none';fullscreen 'none';geolocation 'none';microphone 'none';payment 'none'
2025-11-13 11:48:17.727 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-robots-tag: noindex, nofollow
2025-11-13 11:48:17.728 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I strict-transport-security: max-age=15768000; includeSubDomains; preload
2025-11-13 11:48:17.728 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I referrer-policy: no-referrer
2025-11-13 11:48:17.728 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-content-type-options: nosniff
2025-11-13 11:48:17.728 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-frame-options: SAMEORIGIN
2025-11-13 11:48:17.729 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-permitted-cross-domain-policies: none
2025-11-13 11:48:17.729 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-robots-tag: noindex, nofollow
2025-11-13 11:48:17.729 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I x-xss-protection: 1; mode=block
2025-11-13 11:48:17.731 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I []
2025-11-13 11:48:17.731 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I <-- END HTTP (2-byte body)
2025-11-13 11:48:17.993 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I --> POST https://sermo.nextcloud.com/login/v2/poll
2025-11-13 11:48:17.995 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I Content-Type: application/x-www-form-urlencoded
2025-11-13 11:48:17.995 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I Content-Length: 134
2025-11-13 11:48:17.996 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v23.0.0 Alpha 13
2025-11-13 11:48:17.996 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I Accept: application/json
2025-11-13 11:48:17.996 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I OCS-APIRequest: true
2025-11-13 11:48:17.996 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I ngrok-skip-browser-warning: true
2025-11-13 11:48:17.998 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I token=shtYa8ErLZZzeDaxg0QugStgLmki0w0Cs6R8UHuZR8dUlli1qsdzMUIsSU1saccRpghhhz4xlI0N7ix0jXvjxTZJRWybggMIqkBuo9f8OvqSxmtBBQrx2ip9w95mcgyx
2025-11-13 11:48:17.998 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I --> END POST (134-byte body)
2025-11-13 11:48:18.021 8961-9189 okhttp.OkHttpClient com.nextcloud.talk2 I <-- HTTP FAILED: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-11-13 11:48:18.022 8961-9189 NetworkLoginDataSource com.nextcloud.talk2 E Error caught at performLoginFlowV2: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-11-13 11:48:35.019 8961-9216 HWUI com.nextcloud.talk2 I setGrContext validptr-->nullptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

🖼️ Screenshots
Screen_recording_20251031_113012.webm
🚧 TODO
🏁 Checklist
/backport to stable-xx.x