Allow rewrite of UID for SSO #313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thanks for your contribution! 👍 Sounds like a good idea but I don't have a Kerberos setup to test it at the moment... @icewind1991 do you have a chance to review/test it? |
Author
|
It is not limited to Kerberos, you can use it in other places where the username has to be rewritten (e.g. when the SSO mechanism passes an e-mail address or a full path from LDAP). |
Author
|
Any news here? |
Member
|
@digitalshow thanks for this pr! |
Signed-off-by: Ingo Koinzer <[email protected]>
Signed-off-by: Ingo Koinzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for rewrite of UIDs using preg_replace.
An administrator can provide a pattern and a replacement parameter that get passed to PHP's preg_replace function before the UID is used to sign in to NextCloud. I use it to extract the username from a kerberos principal (pattern:
/^(.*)@REALM$/, replacement:$1).