Skip to content

Conversation

@sunshowers
Copy link
Member

Still to figure out:

  • Write tests for parsing configuration.
  • Write tests which set configuration and ensure that output gets written to the right spot.
  • How should remapped archive directories be handled? Archive target directories are typically temporary directories which will be deleted at the end of the run. Using that as the store directory seems wrong. In that case, we may wish to use another location instead.

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

❌ Patch coverage is 90.62500% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (44e109c) to head (75d27f4).

Files with missing lines Patch % Lines
nextest-runner/src/config/elements/store.rs 89.36% 5 Missing ⚠️
nextest-runner/src/reporter/aggregator/junit.rs 68.75% 5 Missing ⚠️
cargo-nextest/src/errors.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   80.17%   80.20%   +0.03%     
==========================================
  Files         113      114       +1     
  Lines       26312    26362      +50     
==========================================
+ Hits        21096    21144      +48     
- Misses       5216     5218       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trunk-io
Copy link

trunk-io bot commented Feb 16, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@eduardorittner
Copy link

Hi! I've been writing some tests for this in https://github.com/eduardorittner/nextest/tree/store-dir-relative. I'm not sure how to best integrate these changes? Open a PR from my branch to upstream/store-dir-relative? You just copy the commits over?

Also, regarding your third point, do you mean that when store.dir's full path is a temporary directory we should choose another directory? But how can nextest detect when it's a temporary directory? Is there a mechanism for this?

@sunshowers
Copy link
Member Author

Thanks for picking this up. Let me rebase on to main and then you can submit your work as dependent on it.

But how can nextest detect when it's a temporary directory?

Only concerned about temp dirs nextest itself creates in this context, which can be tracked internally.

@sunshowers
Copy link
Member Author

Rebased this on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants