Skip to content

♻️ refactor(cli): add -with-seqera and SEQERA_ACCESS_TOKEN as aliases for nextflow run #6168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Jun 5, 2025

Documentation updates:

  • Updated CLI documentation in docs/reference/cli.md to replace references to -with-tower with -with-seqera, including examples, descriptions, and monitoring instructions. [1] [2] [3] [4]

Code updates for CLI options:

  • Modified nextflow run to support both -with-tower and -with-seqera options for monitoring workflows with the Seqera Platform.
  • Updated Launcher.groovy to normalize arguments for the new -with-seqera option alongside -with-tower.

Test updates:

  • Added test cases in LauncherTest.groovy to ensure the new -with-seqera option is processed correctly.

Importantly, this PR doesn't change the tower config or the TOWER_* environment variables, which could be addressed in a separate PR.

It also is a non-breaking change as previous users using the -with-tower cli arg will be able to continue doing so.

@kenibrewer kenibrewer requested a review from a team as a code owner June 5, 2025 19:53
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 54b79dc
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/688209c85be44a0007c1dc41

@kenibrewer kenibrewer force-pushed the add-seqera-as-tower-alias branch from 98e042b to 1bc43ee Compare June 5, 2025 19:55
@kenibrewer kenibrewer requested review from ewels and pditommaso June 5, 2025 20:00
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!!

The CLI flag is good, the env var is even better.

@kenibrewer kenibrewer force-pushed the add-seqera-as-tower-alias branch 2 times, most recently from 8063c1c to a6732cc Compare July 24, 2025 10:03
Revert addition of SEQERA_ACCESS_TOKEN as an alias for TOWER_ACCESS_TOKEN.
The code now only supports TOWER_ACCESS_TOKEN as before.

- Remove SEQERA_ACCESS_TOKEN priority logic from TowerClient.getAccessToken()
- Remove SEQERA_ACCESS_TOKEN priority logic from PlatformHelper.getAccessToken()
- Revert error messages to only mention TOWER_ACCESS_TOKEN
- Remove updated docstrings mentioning SEQERA_ACCESS_TOKEN support

Signed-off-by: Ken Brewer <[email protected]>
@kenibrewer kenibrewer force-pushed the add-seqera-as-tower-alias branch from a6732cc to 54b79dc Compare July 24, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants