-
Notifications
You must be signed in to change notification settings - Fork 738
Optimize exit code handling by relying on scheduler status for successful executions #6484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
@bentsherman @pditommaso the google batch task handler is directly getting the exit code form the file (#6481). This PR also removes the fallback to .exitcode when the exit code is 0. It is not a big PR but I was wondering if you prefer to split it in two PRs to facilitate backport to stable versions. The fix for #6481 is just the first commit ea1aa48 |
…g-on-scheduler-status-for-successful-executions
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but i'd keep post 25.10
@jorgee we talked and agreed to include the google and k8s fixes in 25.10 and merge the rest of this PR in the next edge release |
close #6445
close #6481
Some cloud provider implementations got exit code from .exitcode files other get from the API and fallback to .exitcode when exitcode was null or 0.
This PR unifies exit code behaviour in all cloud providers.
1- Try to get exitcode form the API
2. If exitcode is missing (null) fallback to read .exitcode
Note: not applied to grid executors