Skip to content

Conversation

jorgee
Copy link
Contributor

@jorgee jorgee commented Oct 14, 2025

close #6445
close #6481

Some cloud provider implementations got exit code from .exitcode files other get from the API and fallback to .exitcode when exitcode was null or 0.
This PR unifies exit code behaviour in all cloud providers.

1- Try to get exitcode form the API
2. If exitcode is missing (null) fallback to read .exitcode

Note: not applied to grid executors

@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit a2114e9
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68ef94ccf3592c0008c0b24a

@jorgee
Copy link
Contributor Author

jorgee commented Oct 14, 2025

@bentsherman @pditommaso the google batch task handler is directly getting the exit code form the file (#6481). This PR also removes the fallback to .exitcode when the exit code is 0. It is not a big PR but I was wondering if you prefer to split it in two PRs to facilitate backport to stable versions. The fix for #6481 is just the first commit ea1aa48

@jorgee jorgee changed the title 6445 optimize exit code handling by relying on scheduler status for successful executions Optimize exit code handling by relying on scheduler status for successful executions Oct 14, 2025
@jorgee jorgee marked this pull request as ready for review October 15, 2025 13:39
@bentsherman bentsherman added this to the 25.10 milestone Oct 16, 2025
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but i'd keep post 25.10

@bentsherman
Copy link
Member

@jorgee we talked and agreed to include the google and k8s fixes in 25.10 and merge the rest of this PR in the next edge release

@bentsherman bentsherman modified the milestones: 25.10, 26.04 Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize exit code handling by relying on scheduler status for successful executions Nextflow doesn't capture Fusion exit codes from Google Batch API

3 participants