Update schemas with build_avatar #818

[sagar-pathak]

Description of proposed changes

Schema information added for build_avatar in schema-annotations.json and schema-export-v2.json file.

Related issue(s)

#818

Checklist

• Automated checks pass
• Check if you need to add a changelog message
• Check if you need to add tests
• Check if you need to update docs

[jameshadfield]

The schema changes look ok, pending the review comment.

Note that this doesn't allow the build_avatar, if set on the auspice-config JSON, to be exported via augur export v2. To achieve that we'd need to extend export_v2.py to pass this through, similar to how it parses build_url (although we wouldn't need to expose this via a command-line arg):

augur/augur/export_v2.py

Lines 1075 to 1080 in 23b9fff

	def set_build_url(data_json, config, cmd_line_build_url):
	# build_url is not necessary. Cmd line args override any config settings
	if cmd_line_build_url:
	data_json['meta']['build_url'] = cmd_line_build_url
	elif config.get("build_url"):
	data_json['meta']['build_url'] = config.get("build_url")

[jameshadfield]

This should follow the form of build_url and reference the definition in the auspice-config to avoid duplication.

[sagar-pathak]

Thanks @jameshadfield, I will work on this.

[jameshadfield]

Also, one more tiny change - can you remove the word "group-specific" - we already have a concept of "Nextstrain groups" which are unrelated to this and I don't want to potentially confuse some people

[sagar-pathak]

I am curious if we really need the else block, since this field is optional. Let me know. @jameshadfield

def set_build_avatar(data_json, config):
    # build_avatar is not necessary. No cmd line args handling
    if config.get("build_avatar"):
        data_json['meta']['build_avatar'] = config.get("build_avatar")

[jameshadfield]

That code snippet looks good. (We don't need the else block because we're not exposing this as a command-line option to augur export)

[sagar-pathak]

@jameshadfield I am not sure why the build is failing. Do you have any idea on how to fix this one?