add rendered product promo sample#35
Open
FahadBinHussain wants to merge 1 commit into
Open
Conversation
lefarcen
added
size/XS
lefarcen
reviewed
Jun 9, 2026
lefarcen
left a comment
lefarcen
left a comment
Contributor
There was a problem hiding this comment.
Hey @FahadBinHussain! 👋 Fast turnaround — you opened this the same morning you claimed it.
The .gitignore negation pattern is exactly right: renders/ catches every other renders directory while the two !docs/assets/renders/ lines carve out the specific asset path. Both READMEs get the same update (English + zh-CN in sync), and the command block uses a clear <project_id> placeholder so readers know where to substitute their own value. The ffprobe metadata in the PR description (1920×1080, 60fps, 14.4s) is a nice verification trail too.
This looks ready from a code standpoint — handing off to a maintainer to merge. ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a real rendered mp4 sample for
frame-product-promoand links it from both readmes.what changed:
docs/assets/renders/frame-product-promo.mp4project-rendercommand shape in the showcase sectiondocs/assets/renders/*.mp4through the generated-video gitignore rulechecks:
pnpm buildnode packages/cli/dist/bin.js project-render proj_d2e348af-c4d --output docs/assets/renders/frame-product-promo.mp4 --stream-progressffprobeshows 14.366667s, 1920x1080, 60fps, 450622 bytescloses #30