Skip to content

fix: allow Origin: null for /api/asset-cache in sandboxed plugin previews #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lefarcen merged 1 commit into from
Jun 19, 2026
Merged

fix: allow Origin: null for /api/asset-cache in sandboxed plugin previews #4487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/daemon/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4755,7 +4755,7 @@ export async function startServer({
// Routes that serve content to sandboxed iframes (Origin: null) for
// read-only purposes. All other /api routes reject Origin: null.
const _NULL_ORIGIN_SAFE_GET_RE =
/^\/projects\/[^/]+\/(?:raw|preview)\/|^\/codex-pets\/[^/]+\/spritesheet$/;
/^\/projects\/[^/]+\/(?:raw|preview)\/|^\/codex-pets\/[^/]+\/spritesheet$|^\/asset-cache$/;

// Reject cross-origin requests to API endpoints.
// Health/version remain open for monitoring probes.
Expand Down
12 changes: 11 additions & 1 deletion apps/daemon/tests/origin-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function closeServer(server: http.Server): Promise<void> {

function createOriginMiddleware(resolvedPort: number, host = '127.0.0.1') {
const _NULL_ORIGIN_SAFE_GET_RE =
/^\/projects\/[^/]+\/raw\/|^\/codex-pets\/[^/]+\/spritesheet$/;
/^\/projects\/[^/]+\/(?:raw|preview)\/|^\/codex-pets\/[^/]+\/spritesheet$|^\/asset-cache$/;
return (req: Request, res: Response, next: NextFunction) => {
const origin = req.headers.origin;
if (origin == null || origin === '') return next();
Expand Down Expand Up @@ -95,6 +95,9 @@ function makeTestApp(port: number, host = '127.0.0.1') {
}
res.type('image/png').send(Buffer.from('fake-sprite'));
});
app.get('/api/asset-cache', (_req, res) => {
res.type('image/png').send(Buffer.from('fake-asset'));
});
return app;
}

Expand Down Expand Up @@ -326,6 +329,13 @@ describe('daemon origin validation middleware', () => {
expect(res.headers['access-control-allow-origin']).toBe('null');
});

it('allows Origin: null for GET asset-cache routes', async () => {
const res = await request(port, 'GET', '/api/asset-cache?url=https%3A%2F%2Fcdn.example.com%2Fhero.webp', {
origin: 'null',
});
expect(res.status).toBe(200);
});

it('rejects Origin: null on POST to state-changing endpoints', async () => {
const res = await request(port, 'POST', '/api/projects', {
origin: 'null',
Expand Down
Loading