-
Notifications
You must be signed in to change notification settings - Fork 912
Add task.ext.suffix for CSVTK_CONCAT #9144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion the file ending should only be an input:. I don't see the case where a user needs to change it, as it could lead to downstream instability.
|
I’m fine with any solution that lets me use it for files other than CSV and TSV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeonHafner , what exactly do you want to be able to do?
|
Currently, you can edit arbitrary text files delimited by any character by specifying the separator in the |
|
Our apologies for the delay in reviewing this, but there's a proposal open to the core team that needs voting that directly affects whether or not this pattern should be used. nf-core/proposals#69 |
|
One option is to just use the suffix of the original file. |
Does one need to worry about compression? Can this module read compressed input? |
This PR adds support for specifying a custom suffix, so pipeline maintainers can work with files beyond just
.csvand.tsv.PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda