Skip to content

Conversation

@dialvarezs
Copy link
Contributor

Adds https://github.com/picrust/picrust2 module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Comment on lines 16 to 17
tuple val(meta), path("${prefix}/*_metagenome_out/pred_metagenome_unstrat.tsv.gz"), emit: function_abundances
tuple val(meta), path("${prefix}/pathways_out/path_abun_unstrat.tsv.gz"), emit: pathway_abundances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, these are quite nested.
Is it sensible to copy these into the base directory with renaming them with ${prefix}?

Copy link
Contributor Author

@dialvarezs dialvarezs Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SPPearce! Sure, that makes sense to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many files does this actually make? Do the downstream tools assume it'll need the subfolders?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on how many functions are enabled. EC and KO are enabled by default, and the full list includes: EC, KO, GO, PFAM, BIGG, CAZY, GENE_NAMES.

Each CSV file can be used independently, so it should be fine to move them out of the output directory (preferably as copies, in case the original directory structure needs to be preserved).

There are a few other files in the output directory (around 20, excluding intermediate files), but these are the main ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants