-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker downloads #3517
base: dev
Are you sure you want to change the base?
Add docker downloads #3517
Conversation
…environment variables
…have to be aware of the TaskID
Codecov ReportAttention: Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you, Nikhil for refactoring #3516 into a separate class for Docker downloads and directly basing it on the other PR. Much appreciated, and apologies again for the fuss and my coordination failure. I will focus getting the refactored Singularity download in first, but then get back to this PR to review and finalize the Docker support. Once that becomes available, it will be the first major new feature for I think, it would be very useful to have Nextflow supporting the |
Sounds good, thanks so much for working on finishing this up! |
Hey, I added a feature request for |
resolves: #2309
This PR adds docker support to the pipeline download functionality
This PR uses the guide to download the image: nextflow-io/nextflow#4708
It mimics Singularity's cache env variable by using the new env variable
NXF_DOCKER_CACHEDIR
, the downside is that this is not an official env in nextflow and the user needs to runon their own as nextflow currently has no way of loading offline tar files
This PR is a rework of #3516, to use the new container class created here: #3509
PR checklist
CHANGELOG.md
is updateddocs
is updated