-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker support in pipeline download #3516
Conversation
…r_support_in_pipeline_download
😱 Yes, that is likely inevitable! Unfortunately, I did not know that you were working on this task at all! We coordinated the other refactors via Zoom and Slack and I have asked multiple times in the channel that people working on tasks should come forward. I was online on Monday and Tuesday until 1.a.m. UTC so people from the Americas could reach out if help was needed. 😰 This is now very unfortunate, but it seemed to be the easiest for testing and maintenance to move all Singularity download functions into a separate class and build an analogous Docker download class later. Do you think that you could move your work into a similar class like in #3509? Basically, one that just takes the container strings and registries and then downloads the container images? |
No worries! I must have missed that on the hackathon slack channel, I added a draft PR of my work into a docker class using the singularity class as a base. Its located here: #3517. Should be good to add once the other PR is in |
I am going to close this PR since this should not get merged |
Resolves: #2309
This PR adds docker support to the pipeline download functionality
This PR uses the guide to download the image: nextflow-io/nextflow#4708
It mimics Singularity's cache env variable by using the new env variable
NXF_DOCKER_CACHEDIR
, the downside is that this is not an official env in nextflow and the user needs to runon their own as nextflow currently has no way of loading offline tar files
PR checklist
CHANGELOG.md
is updateddocs
is updated