-
Notifications
You must be signed in to change notification settings - Fork 201
Feature/test datasets #3494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/test datasets #3494
Conversation
…tch RequestExceptions
Latter is probably best I think, as makes me and you happy but default sticks with the typical nf-core convention |
Oh and one more general question: Whats our stance on type hints @mirpedrol ? Should I add them? |
We are slowly adopting them when we add new code or modify old code, so yes, you should add them 😄 |
…for easier testing
Could you have another look at your previous review @mirpedrol ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of last small suggestions, otherwise LGTM! very nice 🙂
This is a DRAFT.This PR adds functionality to list and search the nf-core/test-datasets github repository via a new subcommand
test-datasets
. Closes #3487 where this feature was requested.Changes:
test-datasets search
,test-datasets list
,test-datasets list-branches
test-datasets
folder with command and utility functionsPR checklist
CHANGELOG.md
is updateddocs
is updated