Refactor module lint tests #3592
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling - Renamed test functions for clarity. - Introduced DummyModule and DummyLint classes to simulate module and lint behavior. - Enhanced tests for handling invalid, empty, and missing dependencies in environment.yml files. - Improved assertions to validate sorting and schema compliance.
- Replaced yaml library with ruamel.yaml for improved YAML processing. - Added schema validation for environment.yml files. - Implemented sorting for dependencies and channels, ensuring proper order. - Updated file writing to include schema lines and sorted content. - Enhanced logging for sorting actions and validation results.
…processing - Updated the YAML library from ruamel.yaml to PyYAML for improved compatibility. - Changed YAML loading to use safe_load for better security. - Enhanced YAML dumping with specific formatting options for clarity. - Adjusted error handling to reflect the new library usage.
Did my best, and wanted to keep the code verbatim before things really start shifting.
… version handling - Introduced separate test files for module changes, deprecations, todos, and version functionalities. - Implemented basic structure and placeholder tests for each new test file to ensure future functionality can be added. - Removed the old test_lint.py file to streamline the test organization.
…ssed tests - Updated the assertion to verify the presence of "test_snap_md5sum" in the passed tests. - Improved handling to accommodate both LintResult objects and tuple formats for better robustness.
Codecov ReportAll modified and coverable lines are covered by tests ✅
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can you make this independent from #3591 ? Difficult to see the changes otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3591
PR checklist
CHANGELOG.mdis updateddocsis updated