Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
fd54207
fixes to registration modules, renaming to unify nomenclature
AlexVCaron Jul 17, 2025
98ebf28
ants works
AlexVCaron Jul 17, 2025
af85c5a
MODULES : align naming conventions, order of inputs, output both sing…
AlexVCaron Jul 18, 2025
9994f48
SUBWORKFLOWS : work in progress
AlexVCaron Jul 18, 2025
57f60db
realign all modules interfaces. update meta
AlexVCaron Jul 20, 2025
a2e7f0e
realign registration subworkflow. update meta. fixes all around
AlexVCaron Jul 20, 2025
4cac672
organize and fix registration modules configuration. Handle edge case…
AlexVCaron Jul 28, 2025
2a016a8
enable full registration subworkflow in bundle_seg wuubworkflow
AlexVCaron Jul 28, 2025
125c6ff
switch for registration sbwf in output_template_space. test synthmorp…
AlexVCaron Jul 28, 2025
84bfdea
lint subworkflows
AlexVCaron Jul 29, 2025
6eaab67
lint modules
AlexVCaron Jul 29, 2025
932548d
extract extension variable
AlexVCaron Jul 30, 2025
86c9a64
fix fiable errors (convert is still a mystery)
AlexVCaron Jul 30, 2025
e5b02ab
just to see
AlexVCaron Jul 30, 2025
fe358e2
re-enable stubbed subworkflow runs
AlexVCaron Jul 30, 2025
8c4a867
bump nextflow version used in tests
AlexVCaron Jul 30, 2025
bb870a3
remove limitations on subworkflows (no need for bigmem when running s…
AlexVCaron Jul 30, 2025
fb2516c
fix invalid streamline management
AlexVCaron Jul 30, 2025
b91e73b
remove debug prints
AlexVCaron Jul 31, 2025
8bc4477
fix prettier
AlexVCaron Sep 24, 2025
71a52a9
fix lint
AlexVCaron Sep 24, 2025
b3e03a1
fix tests
AlexVCaron Sep 24, 2025
691aea5
update tests and meta.
AlexVCaron Oct 8, 2025
efc3a23
update subworkflows tests
AlexVCaron Oct 10, 2025
c18142d
uniformize naming, fix convert -h in stubs (bad), scope trap to preve…
AlexVCaron Oct 15, 2025
554a00e
update devcontainer to scilus 2.2.0
AlexVCaron Oct 15, 2025
c2c7e3c
add entrypoint to ensure pipx dependencies loading
AlexVCaron Oct 15, 2025
1d1631a
resnap registration subworkflow
AlexVCaron Oct 15, 2025
ae8a860
remove workdir collection
AlexVCaron Oct 15, 2025
70ec5c3
naming conventions and resnap
AlexVCaron Oct 16, 2025
064ea75
move synthregistration to synthmorph. Fix antsapplytransforms suffix
AlexVCaron Oct 16, 2025
10b7680
finish filenaming update to synthmorph + fixes
AlexVCaron Oct 16, 2025
655586a
fix antsapplytransforms. resnap subworkflows versions
AlexVCaron Oct 16, 2025
5b55b4e
add timeout to retried steps in github workflows, to try to unstuck l…
AlexVCaron Oct 16, 2025
9219517
remove retries, as they seem to hang up the workflows
AlexVCaron Oct 16, 2025
74181e9
snapshot update
AlexVCaron Oct 24, 2025
5865aa6
need to be part of root group to copy the license correctly. Tested o…
AlexVCaron Oct 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .devcontainer/devops/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,5 @@ RUN pipx ensurepath && \
# Export history for saving between container sessions
RUN SNIPPET="export PROMPT_COMMAND='history -a' && export HISTFILE=/home/$USERNAME/commandhistory/.bash_history" \
&& echo "$SNIPPET" >> "/home/$USERNAME/.bashrc"

ENTRYPOINT ["/bin/sh", "-lc", "pipx ensurepath && exec \"$@\""]
23 changes: 7 additions & 16 deletions .github/workflows/lint_component.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,33 +45,24 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup Python
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
attempt_delay: 5000
action: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with: |
python-version: "3.10"
python-version: "3.10"

- uses: abatilo/actions-poetry@7b6d33e44b4f08d7021a1dee3c044e9c253d6439 # v3.0.0
with:
poetry-version: "1.8.*"

- name: Setup Java
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with:
attempt_delay: 5000
action: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with: |
distribution: "temurin"
java-version: "17"
distribution: "temurin"
java-version: "17"

- name: Setup nextflow
uses: Wandalen/wretry.action@v3.7.2
uses: nf-core/setup-nextflow@561fcfc7146dcb12e3871909b635ab092a781f34 # v2.0.0
with:
attempt_delay: 5000
action: nf-core/setup-nextflow@561fcfc7146dcb12e3871909b635ab092a781f34 # v2.0.0
with: |
version: ${{ inputs.nextflow_version }}
version: ${{ inputs.nextflow_version }}

- name: Install nf-core tools
run: |
Expand Down
37 changes: 11 additions & 26 deletions .github/workflows/run_checks_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
description: "Nextflow version to use"
required: false
type: string
default: "24.04.4"
default: "25.04.6"
nf_core_version:
description: "nf-core version to use"
required: false
Expand All @@ -25,13 +25,10 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup Python
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
attempt_delay: 5000
action: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with: |
python-version: "3.11"
cache: "pip"
python-version: "3.11"
cache: "pip"

- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
# FIXME Flip this off once we get to less than a couple hundred. Adding
Expand All @@ -46,13 +43,10 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup Node
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
attempt_delay: 5000
action: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with: |
node-version: "20"
cache: "npm"
node-version: "20"
cache: "npm"

- name: Install Prettier
run: npm ci
Expand All @@ -66,13 +60,10 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup Node
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
attempt_delay: 5000
action: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with: |
node-version: "20"
cache: "npm"
node-version: "20"
cache: "npm"

- name: Install editorconfig-checker
run: npm ci
Expand Down Expand Up @@ -193,13 +184,7 @@ jobs:
- runner: scilus-docker-large
path: modules/nf-neuro/betcrop/synthbet
- runner: scilus-docker-large
path: modules/nf-neuro/registration/synthregistration
- runner: scilus-docker-large
path: subworkflows/nf-neuro/preproc_t1
- runner: scilus-docker-large
path: subworkflows/nf-neuro/registration
- runner: scilus-docker-large
path: subworkflows/nf-neuro/anatomical_segmentation
path: modules/nf-neuro/registration/synthmorph
exclude:
- path: subworkflows/nf-neuro/load_test_data
uses: ./.github/workflows/test_component.yml
Expand Down
47 changes: 9 additions & 38 deletions .github/workflows/test_component.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,30 +77,22 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Setup Python
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
attempt_delay: 5000
action: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with: |
python-version: "3.11"
cache: "pip"
python-version: "3.11"
cache: "pip"

- name: Setup Java
uses: Wandalen/wretry.action@v3.7.2
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with:
attempt_delay: 5000
action: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with: |
distribution: "temurin"
java-version: "17"
distribution: "temurin"
java-version: "17"

- name: Setup nextflow
uses: Wandalen/wretry.action@v3.7.2
uses: nf-core/setup-nextflow@561fcfc7146dcb12e3871909b635ab092a781f34 # v2.0.0
with:
attempt_delay: 5000
action: nf-core/setup-nextflow@561fcfc7146dcb12e3871909b635ab092a781f34 # v2.0.0
with: |
version: ${{ inputs.nextflow_version }}
version: ${{ inputs.nextflow_version }}

- uses: nf-core/setup-nf-test@fbd9d701dd1f41a38b151a737a0f12e97f3c4c56 # v1.3.5
with:
version: ${{ inputs.nf_test_version }}
Expand Down Expand Up @@ -197,27 +189,6 @@ jobs:
retention-days: 1
compression-level: 9

- name: Collect test working directories
if: failure()
run: |
mkdir -p tests_workdir
for t in ${{ env.NXF_WORKDIR }}/.nf-test/tests/**/work/**/.command.log
do
tag=$(sed -n '3p' $(dirname $t)/.command.run | cut -d' ' -f3 | tr -d "'")
cp -R $(dirname $t) tests_workdir/$tag
done

- name: Upload test working directories
if: failure()
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
with:
name: tests-workdir-${{ steps.test-run-identifier.outputs.uid }}
path: tests_workdir/
overwrite: true
retention-days: 1
compression-level: 9
include-hidden-files: true

- name: Clean up
if: always()
run: |
Expand Down
12 changes: 9 additions & 3 deletions modules/nf-neuro/bundle/recognize/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,19 @@ process BUNDLE_RECOGNIZE {
def rbx_processes = task.cpus ? "--processes " + task.cpus : "--processes 1"
def outlier_alpha = task.ext.outlier_alpha ? "--alpha " + task.ext.outlier_alpha : ""
"""
if [[ "$transform" == *.txt ]]; then
ConvertTransformFile 3 $transform transform.mat --convertToAffineType \
&& transform="transform.mat" \
|| echo "TXT transform file conversion failed, using original file."
fi

mkdir recobundles/
scil_tractogram_segment_with_bundleseg ${tractograms} ${config} ${directory}/ ${transform} --inverse --out_dir recobundles/ \
-v DEBUG $minimal_vote_ratio $seed $rbx_processes

for bundle_file in recobundles/*.trk; do
bname=\$(basename \${bundle_file} .trk)
out_cleaned=${prefix}__\${bname}_cleaned.trk
bname=\$(basename \${bundle_file} .trk | sed 's/${prefix}_\\+//')
out_cleaned=${prefix}_\${bname}_cleaned.trk
scil_bundle_reject_outliers \${bundle_file} "\${out_cleaned}" ${outlier_alpha}
done

Expand All @@ -46,7 +52,7 @@ process BUNDLE_RECOGNIZE {
scil_bundle_reject_outliers -h

# dummy output for single bundle
touch ${prefix}__AF_L_cleaned.trk
touch ${prefix}_AF_L_cleaned.trk

cat <<-END_VERSIONS > versions.yml
"${task.process}":
Expand Down
40 changes: 20 additions & 20 deletions modules/nf-neuro/bundle/recognize/tests/main.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"id": "test",
"single_end": false
},
"test__bundle_1_cleaned.trk",
"test__bundle_2_cleaned.trk",
"test__bundle_3_cleaned.trk",
"test__bundle_4_cleaned.trk",
"test__bundle_5_cleaned.trk"
"test_bundle_1_cleaned.trk",
"test_bundle_2_cleaned.trk",
"test_bundle_3_cleaned.trk",
"test_bundle_4_cleaned.trk",
"test_bundle_5_cleaned.trk"
]
],
"versions": [
Expand All @@ -21,10 +21,10 @@
}
],
"meta": {
"nf-test": "0.9.2",
"nextflow": "25.04.7"
"nf-test": "0.9.0",
"nextflow": "25.04.8"
},
"timestamp": "2025-09-17T17:40:02.174844814"
"timestamp": "2025-10-16T16:21:06.178446125"
},
"bundle - recognize - stub-run": {
"content": [
Expand All @@ -35,7 +35,7 @@
"id": "test",
"single_end": false
},
"test__AF_L_cleaned.trk"
"test_AF_L_cleaned.trk"
]
],
"versions": [
Expand All @@ -45,9 +45,9 @@
],
"meta": {
"nf-test": "0.9.0",
"nextflow": "25.04.7"
"nextflow": "25.04.8"
},
"timestamp": "2025-09-17T17:40:14.633526447"
"timestamp": "2025-10-16T16:21:40.42494296"
},
"bundle - recognize - base": {
"content": [
Expand All @@ -58,11 +58,11 @@
"id": "test",
"single_end": false
},
"test__bundle_1_cleaned.trk",
"test__bundle_2_cleaned.trk",
"test__bundle_3_cleaned.trk",
"test__bundle_4_cleaned.trk",
"test__bundle_5_cleaned.trk"
"test_bundle_1_cleaned.trk",
"test_bundle_2_cleaned.trk",
"test_bundle_3_cleaned.trk",
"test_bundle_4_cleaned.trk",
"test_bundle_5_cleaned.trk"
]
],
"versions": [
Expand All @@ -71,9 +71,9 @@
}
],
"meta": {
"nf-test": "0.9.2",
"nextflow": "25.04.7"
"nf-test": "0.9.0",
"nextflow": "25.04.8"
},
"timestamp": "2025-09-17T17:39:29.968449034"
"timestamp": "2025-10-16T16:20:14.719020953"
}
}
}
Loading
Loading