Skip to content

update containers - module registration#195

Merged
arnaudbore merged 3 commits intonf-neuro:mainfrom
arnaudbore:update_containers_registration
Sep 24, 2025
Merged

update containers - module registration#195
arnaudbore merged 3 commits intonf-neuro:mainfrom
arnaudbore:update_containers_registration

Conversation

@arnaudbore
Copy link
Contributor

Type of improvement

If submitting a new module or fixing a bug, please use the appropriate template.

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Write a clear and concise description of what the improvement is.

Describe how to test your improvement

Provide a full step-by-step guide to test your improvement.

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

gagnonanthony
gagnonanthony previously approved these changes Sep 22, 2025
Copy link
Member

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some conflicts, but once resolved good to go! 🔥

Copy link
Contributor

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job ! 👏🏼 On fix for tractogram I'd like to have now, since it's a quick win, else it's all perfect !

Copy link
Member

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnaudbore arnaudbore merged commit 065ceb3 into nf-neuro:main Sep 24, 2025
54 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments