ENH: Switch major subworkflows params to inputs via a map of parameters#304
Merged
AlexVCaron merged 5 commits intonf-neuro:mainfrom Feb 12, 2026
Merged
Conversation
AlexVCaron
requested changes
Feb 12, 2026
Contributor
AlexVCaron
left a comment
There was a problem hiding this comment.
Major discussion point here, I see that we passed over it in recent PRs. What is expected to default to True, and what's not ? Now, with optionality, most preprocessing gets skipped (since null params evaluates to false). We should take a pause and fix that here
Member
Author
|
I think, since the optionality will now be documented in the I also think setting default can be done two ways:
If we start mixing what is by default true and what's not, it can get more confusing rapidly. |
arnaudbore
approved these changes
Feb 12, 2026
AlexVCaron
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of improvement
If submitting a new module or fixing a bug, please use the appropriate template.
Describe your improvement
The use of
paramswithin subworkflow were creating issues when we were trying to bind pipeline level parameters with subworkflow levels parameters. This PR switches allparams.*withinpreproc_t1,preproc_dwi,topup_eddy, andtractoflowto a map of paramters supplied as an input calledoptions.Describe how to test your improvement
Run the tests
Checklist before requesting a review