Skip to content

feat: Update mainline NGINX to 1.29.1 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

feat: Update mainline NGINX to 1.29.1 #339

merged 1 commit into from
Aug 18, 2025

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Aug 17, 2025

Proposed changes

This PR updates mainline NGINX to 1.29.1. It also updates NJS to 0.9.1 and adds the --batch flag to all gpg invocations.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have run the update.sh script and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • I have tested that the NGINX Docker unprivileged image builds and runs correctly on all supported architectures on an unprivileged environment (check out the README for more details)
  • I have updated any relevant documentation (README.md)

* Update NJS to 0.9.1
* Use --batch for all `gpg` invocations
@Copilot Copilot AI review requested due to automatic review settings August 17, 2025 15:36
@alessfg alessfg requested a review from a team as a code owner August 17, 2025 15:36
@alessfg alessfg self-assigned this Aug 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mainline NGINX Docker images from version 1.29.0 to 1.29.1, along with updating NJS from 0.9.0 to 0.9.1. Additionally, it adds the --batch flag to GPG commands to improve non-interactive execution in Docker builds.

  • Updates NGINX mainline version from 1.29.0 to 1.29.1
  • Updates NJS version from 0.9.0 to 0.9.1
  • Adds --batch flag to GPG commands for better non-interactive behavior

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
update.sh Updates version definitions and package checksums for mainline NGINX and NJS
stable/debian/Dockerfile Adds --batch flag to GPG commands
mainline/debian/Dockerfile Updates NGINX/NJS versions, checksums, and adds --batch flag to GPG commands
mainline/debian-perl/Dockerfile Updates base image version and package checksum
mainline/debian-otel/Dockerfile Updates base image version and package checksum
mainline/alpine/Dockerfile Updates base image version, NJS version, and package checksum
mainline/alpine-slim/Dockerfile Updates NGINX version and package checksum
mainline/alpine-perl/Dockerfile Updates base image version and package checksum
mainline/alpine-otel/Dockerfile Updates base image version and package checksum
Dockerfile-debian.template Adds --batch flag to GPG commands in the template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alessfg alessfg added the enhancement New feature or request label Aug 17, 2025
@alessfg
Copy link
Member Author

alessfg commented Aug 18, 2025

The build is failing due to how the pipeline works. Since the first builds in the sequence did succeed, the rest should work too once the images are actually pushed.

@alessfg alessfg merged commit 872c2c0 into main Aug 18, 2025
16 of 19 checks passed
@alessfg alessfg deleted the update-nginx branch August 18, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants