Fix variable names with modname in module Makefile #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In Makefile.module-*, variable names should use underscores (_) instead of dashes (-) in module names.
This convention is followed in code such as alpine/Makefile:114 and debian/Makefile:116.
For example, the version variable for the headers-more module in Makefile.headers-more is defined as
MODULE_VERSION_headers_more
.However,
build_module.sh
currently generatesMakefile.module-$MODULE_NAME
using the module name as-is in variable names, without converting dashes to underscores.As a result, modules with dashes in their names cannot be built correctly.
This patch addresses the issue by ensuring that module names used in variable names have dashes replaced with underscores.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.md
and/orCHANGELOG.md
).