Skip to content

Fix variable names with modname in module Makefile #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simayosi
Copy link

Proposed changes

In Makefile.module-*, variable names should use underscores (_) instead of dashes (-) in module names.
This convention is followed in code such as alpine/Makefile:114 and debian/Makefile:116.
For example, the version variable for the headers-more module in Makefile.headers-more is defined asMODULE_VERSION_headers_more.

However, build_module.sh currently generates Makefile.module-$MODULE_NAME using the module name as-is in variable names, without converting dashes to underscores.
As a result, modules with dashes in their names cannot be built correctly.

This patch addresses the issue by ensuring that module names used in variable names have dashes replaced with underscores.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant