Skip to content

Conversation

ninogjoni
Copy link

No description provided.

@mhadaily
Copy link
Contributor

mhadaily commented Aug 7, 2023

@ninogjoni Thank you for the PR, it looks pretty ok, but there are lots of formatting changes that are not really necessary for this PR, can you ensure that those are fixed? also please take care of the failed CI checks.

@ninogjoni
Copy link
Author

@mhadaily I corrected things and did an analysis locally beforehand with melos analyze, which was successful this time.

@mhadaily
Copy link
Contributor

Awesom, thank you, I will merge this and publish a new version soon

@totzk9
Copy link
Contributor

totzk9 commented Aug 21, 2023

Hi, can we update it to http 1.1.0 instead?

@ninogjoni
Copy link
Author

Hi, can we update it to http 1.1.0 instead?

Link

@mhadaily
Copy link
Contributor

Hey @ninogjoni

I am sorry again but I tried to start reviewing and merge this PR but it looks like now we have lots of conflicts on your branch. can you take a look?

@ninogjoni
Copy link
Author

Hi @mhadaily

There were still my auto formatting changes in the workflows... Also, three packages have already been updated to x.x.1 (see #102) didn't know now if my changes could also go in there. Or will there be conflicts with pub.dev?

@mhadaily
Copy link
Contributor

mhadaily commented Aug 29, 2023 via email

@ninogjoni
Copy link
Author

ninogjoni commented Aug 29, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants