Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Jul 9, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Fixes the check_latest_release workflow (hopefully).

There were several major issues with the script that I found:

  • PowerShell is the default shell type, but the script was written in Bash
  • github.event_name, etc. can't be accessed the same way in the script as they can in step arguments
    • Also, release.tag_name needs to be parsed from a JSON file, manually, to access it within the script
    • There's supposed to be an INPUT_RELEASE_TAG variable created for us to access the input when manually triggering, but it wasn't there in the environment variables, so we have to get it from the JSON file, too.
  • Though the &&, || worked in the step argument where it was originally used, it does not work within the shell script. We need an if, else

List issues fixed by this Pull Request below, if any.

What testing has been done?

After realizing I couldn't trigger a manual run of the workflow against my fork branch, I created a branch with the same changes in this repo and ran the workflow against it.

It succeeded. I don't know if this will fix the issue of the release tag not automatically triggering the workflow, but we can test that after this goes in.

@ni-jfitzger ni-jfitzger requested a review from marcoskirsch as a code owner July 9, 2025 02:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (8a06f63) to head (0fe45d0).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   89.72%   91.25%   +1.53%     
==========================================
  Files          61       67       +6     
  Lines       14339    16386    +2047     
==========================================
+ Hits        12865    14953    +2088     
+ Misses       1474     1433      -41     
Flag Coverage Δ
codegenunittests 84.44% <ø> (-0.51%) ⬇️
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (?)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 86.72% <ø> (-0.53%) ⬇️
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a06f63...0fe45d0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_latest_release workflow is broken

2 participants