Skip to content

Gn 244 update bnf bnfc logos #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizaadebowale merged 12 commits into from
Jan 5, 2026
Merged

Gn 244 update bnf bnfc logos #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f918a8b
GN-244 update BNFC label in services config
beccadawson Nov 12, 2025
439c6de
GN-244 Add non-breaking space for BNFC text
shilpanice Dec 3, 2025
a004989
GN-244 Update BNF and BNFC logos
shilpanice Dec 3, 2025
7777392
GN-244 Updated failing snapshots
shilpanice Dec 8, 2025
04fa074
GN-244 Update BNF to BNFC
shilpanice Dec 8, 2025
94a2a52
GN-244 Update failing snapshots
shilpanice Dec 8, 2025
459c0d8
GN-244 update to use no-whitespace version of CKS logo and add paddin…
beccadawson Dec 9, 2025
24db017
Merge branch 'GN-244-update-bnf-bnfc-logos' of https://github.com/nic…
beccadawson Dec 9, 2025
9ba30e7
GN-244 add unabbreviated 'BNF' to title used to expand BNFC abbreviat…
beccadawson Dec 9, 2025
c5a4e73
GN-244 add missing L/R padding value for subnav images
beccadawson Dec 9, 2025
2d70945
GN-244 update snapshots to reflect updated abbreviation accessibility…
beccadawson Dec 9, 2025
71b54e3
GN-244 prettier:fix
beccadawson Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Footer/__snapshots__/Footer.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ exports[`Footer Matches snapshot 1`] = `
<abbr
title="British National Formulary for Children"
>
British National Formulary for Children (BNFC)
BNF for Children (BNFC)

<span
class="visuallyHidden"
Expand Down
1 change: 1 addition & 0 deletions src/Header/Nav/SubNav/SubNav.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,5 @@

.image {
height: 100%;
padding: utils.rem(spacing.$small + spacing.$x-small 0);
}
5 changes: 4 additions & 1 deletion src/Header/Nav/SubNav/images/bnf.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
52 changes: 4 additions & 48 deletions src/Header/Nav/SubNav/images/bnfc.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 17 additions & 8 deletions src/Header/Nav/SubNav/images/cks.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/Header/__snapshots__/Header.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ exports[`Header Matches snapshot 1`] = `
</a>
</li>
<li
data-tracking="British National Formulary for Children (BNFC)"
data-tracking="BNF for Children (BNFC)"
>
<a
aria-label="British National Formulary for Children (BNFC)"
Expand All @@ -234,7 +234,7 @@ exports[`Header Matches snapshot 1`] = `
id="navlink-bnfc"
>
<span>
British National Formulary for Children (BNFC)
BNF for Children (BNFC)
</span>
</a>
</li>
Expand Down
3 changes: 1 addition & 2 deletions src/services.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
{
"host": "bnfc.nice.org.uk",
"landingPath": "/",
"text": "British National Formulary for Children (BNFC)",
"text": "BNF for Children\u00A0(BNFC)",
"abbreviation": "BNFC",
"title": "British National Formulary for Children",
"id": "bnfc",
Expand Down Expand Up @@ -149,7 +149,6 @@
"header": false
}
],

"internal": [
{
"host": "www.nice.org.uk",
Expand Down