Fix: Smolagents LiteLLMModel ChatMessage compatibility#3
Open
vinayak-shanawad wants to merge 1 commit intonicknochnack:mainfrom
Open
Fix: Smolagents LiteLLMModel ChatMessage compatibility#3vinayak-shanawad wants to merge 1 commit intonicknochnack:mainfrom
vinayak-shanawad wants to merge 1 commit intonicknochnack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
fastacp.pyscript was encounteringAttributeError: 'dict' object has no attribute 'role' when interacting withsmolagents.models.LiteLLMModel`.Root Cause
This was due to a mismatch in the expected message format.
LiteLLMModelexpectssmolagents.models.ChatMessageobjects with theircontentstructured as a list of dictionaries (even for pure text, e.g.,[{"type": "text", "text": "our_message"}]), while the script was sometimes passing plain dictionaries orChatMessageobjects with stringcontent.Solution
This PR implements minimal changes to ensure all messages passed to
LiteLLMModelaresmolagents.models.ChatMessageinstances, and theircontentattribute consistently follows thelist[dict]format. Specifically:ChatMessage as SmolAgentsChatMessageandMessageRolefromsmolagents.models.MultiStepAgent.input_messagesto explicitly storeSmolAgentsChatMessage.MultiStepAgent.write_memory_to_messagesto act as a guardian, converting messages to the correctSmolAgentsChatMessageobject type and formatting content aslist[dict]before passing to the modelSmolAgentsChatMessagewithcontent=[{"type": "text", "text": "..."}]stepfunction to correctly extract text from thelist[dict] model_message.content.Link to issue: #2