Make credential secret names configurable in claude-dev.sh (#150) - #177
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes nightjarrr/adda-dev-runtime#31.
key, so multiple credentials can coexist under the sameservice/accountnamespace — unblocking simultaneous per-repoclaude-dev.shsessions (each with a single-repo-scoped GitHub token).servicestays hardcoded asclaude-dev.accountvalues are renamed to identify the target system (github,claude,deepseek);keyidentifies the credential within that system and is configured per-repo inclaude-dev.env.CLAUDE_DEV_KEYRING_GITHUB_KEY,CLAUDE_DEV_KEYRING_CLAUDE_KEY,CLAUDE_DEV_KEYRING_DEEPSEEK_KEYtoscripts/claude-dev.env(allrequire_var-validated, fail-fast on missing).docs/CLAUDE-DEV-ENVIRONMENT.md(schema table, bootstrap snippets, retrieval snippet) anddocs/CURRENT-STATE.mdconfig-variable list to match.Out of scope / deferred
CLAUDE-DEV-ENVIRONMENT.md(now three credentials) is deferred to a follow-up docs chore.account=github-tokenetc. → new three-attribute form) is performed by PO post-merge via an ad-hoc helper; not committed.Test plan
bash -n scripts/claude-dev.sh(Coder, static)keyring_lookupsignature ↔ three call sites ↔ env vars ↔ doc snippets (Coder, static)ruff check --fix,ruff format,pytest) — PASS_KEYvar temporarily removed and confirms fail-fast error (live, requires Docker/tmux/secret-tool/keyring — outside Coder's environment)claude-dev.shend-to-end against the molim repo