Skip to content

fix(backend): check if user exists on registration to prevent raw database errors (fix #94) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nirakarpatel merged 2 commits into from
Jul 8, 2026
Merged

fix(backend): check if user exists on registration to prevent raw database errors (fix #94) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e31f7
fix(backend): check if user exists on registration to prevent raw dat…
Pratyush-Panda-2006 Jul 8, 2026
b48b73c
fix(backend/security): sanitize user input in User queries to prevent…
Pratyush-Panda-2006 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/src/Utils/Validetor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import validator from "validator"
const Validate = (data) => {
const { name, email, password } = data;

if (!name || !email || !password) {
throw new Error("Some Field Missing");
if (typeof name !== "string" || typeof email !== "string" || typeof password !== "string") {
throw new Error("Invalid field type");
}

// Optional: Email validation
Expand Down
12 changes: 10 additions & 2 deletions backend/src/controllers/userAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ export const register = async (req, res) => {
Validate(req.body);
const { name, email, password } = req.body;

const existingUser = await User.findOne({ email: String(email) });
if (existingUser) {
return res.status(400).json({
success: false,
error: "User already exists. Please login instead.",
});
}

const hashedPassword = await bcrypt.hash(password, 10);

const user = await User.create({
Expand Down Expand Up @@ -52,11 +60,11 @@ export const login = async (req, res) => {
try {
const { email, password } = req.body;

if (!email || !password) {
if (typeof email !== "string" || typeof password !== "string") {
throw new Error("Invalid Credentials");
}

const user = await User.findOne({ email });
const user = await User.findOne({ email: String(email) });

if (!user) throw new Error("User not found");

Expand Down
Loading