fix: Replace args with VariadicPlaceholder should remove trailing comma #1125
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
samsonasik
changed the title
|
@nikic @TomasVotruba I've applied fix 👍 Ready for review/merge 👍 |
samsonasik
force-pushed
the
variadic-no-trailing-comma
branch
from
5f9899c to
5e60691
Compare
|
@TomasVotruba I've moved test under The patch seems still needs on token level tho as far as I can understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this PR add test and fix for rector case:
which currently we tweak via token there, that would be great if can be fixed in php-parser printer itself.
Ref https://3v4l.org/p6XC3