Track write transactions which do not call write operations - #16
Merged
Conversation
A write transaction that opens, calls no store or delete, and commits still takes the single writer lock of the storage engine. The vault reported no difference between it and a transaction that writes, so the waste stayed invisible. The transaction now carries whether a collection called store or delete through it, and reports that with the commit. The metric vault_write_transactions_total gains a called_write_operation label, and the Vault row of the yacynode dashboard shows the share of commits that wrote nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice to have to see that we do not use write transactions for read operations