clang: Fix build with LLVM 19 #389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er2off
force-pushed
the
clang19
branch
4 times, most recently
from
5c14fa4 to
3f63051
Compare
andrijzyn
reviewed
Dec 20, 2024
| @@ -1350,7 +1352,8 @@ inline int CDmaStringArrayBase<B>::InsertBefore( int elem, const char *pValue ) | |||
| template< class E, class B > | |||
| inline UtlSymId_t CDmaElementArrayConstBase<E,B>::GetElementType() const | |||
| { | |||
| return this->Data().m_ElementType; | |||
| // Fuck MSVC, anyway I'm unsure about if this code was called | |||
|
Why hasn't this been merged yet? |
because this project is kind of dead |
Oh no! I was just following a guide for something that used this, and ran into a error that this PR fixes, did not notice it was dead. Though source is pretty old now. |
or maintainer (aka author of repository) is lazy |
the end result is the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #379.