Skip to content

Update for 1.6 issue #23956 #24909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: version-1-6
Choose a base branch
from

Conversation

Zectbumo
Copy link
Contributor

@Zectbumo Zectbumo commented Apr 24, 2025

OpenBSD is still on Nim 1.x so the fix for #23956 should be in there too

@Araq
Copy link
Member

Araq commented Apr 25, 2025

Ping @narimiran

@narimiran
Copy link
Member

narimiran commented Apr 25, 2025

version-1-6 is dead, baby. version-1-6 is dead.

@Zectbumo
Copy link
Contributor Author

I'm not sure about dead quite yet. OpenBSD 7.7 was just released yesterday and the only Nim package provided is 1.6.18. I tried compiling Nim 2.2.4 from source on amd64 OpenBSD 7.7 and I ran into minor compilation issues where openbsd wasn't mentioned in a when-case and koch tools failed when compiling nimble because it used posix_fallocate but I was successful after making some minor patches so this made me hopeful to see 2.2 available for a package in the next 7.8 release.

I ran testament all and got, what I think is, a decent score: FAILURE! total: 517 passed: 501 skipped: 12 failed: 4

@narimiran
Copy link
Member

the only Nim package provided is 1.6.18

This means they not using even the latest released 1.6 version — 1.6.20.

If we merge this (and before that, we need to update our CIs in the version-1-6 branch, and who knows what more), why do you think they'll switch to some random unreleased commit? (There are no plans of another 1.6.x release.)


I tried compiling Nim 2.2.4 from source on amd64 OpenBSD 7.7 and I ran into minor compilation issues

  1. Is Nim 2.0.16 any better?
  2. Can you report/fix those issues in devel, and we can then backport them to version-2-2?

@Zectbumo
Copy link
Contributor Author

This means they not using even the latest released 1.6 version — 1.6.20.

Right, I'll request for that to be updated. It was 1.6.18 for the last OpenBSD release too.

There are no plans of another 1.6.x release.

Understood. Not a problem to skip this merge. I can submit a patch to the OpenBSD package that can add it to 1.6.20. There are already four patches as it is:
build.sh
config/nim.cfg
dist/nimble/src/nimblepkg/options.nim
lib/pure/asyncnet.nim

  1. Is Nim 2.0.16 any better?

Nim 2.0.16 took the exact same patches to allow compiling of tools and got testament all result of:
FAILURE! total: 101 passed: 36 skipped: 0 failed: 65

  1. Can you report/fix those issues in devel, and we can then backport them to version-2-2?

Yes. issue #24922 and pull #24923
and nimble pull request already being merged.

@Zectbumo
Copy link
Contributor Author

Zectbumo commented Apr 30, 2025

try later, if needed, if you get 500 error from the cvsweb openbsd server. they must be getting slammed from the new release
or use github mirror https://github.com/openbsd/ports/tree/master/lang/nim/patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants