Skip to content

fixes #25174; tyOr handling in tyBuiltInTypeClass branch of typeRel #25177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

fixes #25174; tyOr handling in tyBuiltInTypeClass branch of typeRel #25177

wants to merge 4 commits into from
+35 −5

Conversation

@Graveflo
Copy link
Contributor

Araq
Araq reviewed Sep 17, 2025
View reviewed changes
compiler/sigmatch.nim Outdated
c.inheritancePenalty = oldInheritancePenalty
if bestMatch > isNone:
c.inheritancePenalty = bestPenatly
result = bestMatch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Instead the later disambiguation phase should pick it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the later phases actually don't handle tyOr precisely. You're right though, if I made this unique I probably shouldn't have. I think the failures are coming from binding issues. Might be a deeper problem here unfortunately.

@Graveflo
Copy link
Contributor Author

Graveflo commented Oct 19, 2025 •
edited
Loading

been messing with this some for a while. There might be another work around but this has run into the "liftParamType got messed up and was never fixed" thing again. Also there are type graphs created that boil down two testing to tyObject types that are exactly the same, even referring to the same symbol and sameObjectTypes does not recognize that they are the same. Not sure if I can fix this one any time soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Araq Araq Araq left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Graveflo @Araq